Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round floats for hashing in instrument module, use __slots__ #1986

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 1, 2022

No __slots__ for CameraGeometry as it is incompatible with using lazyproperty.

@maxnoe maxnoe marked this pull request as ready for review July 1, 2022 16:42
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1986 (5cecb1c) into master (4272a4b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   92.21%   92.24%   +0.02%     
==========================================
  Files         193      193              
  Lines       15379    15430      +51     
==========================================
+ Hits        14182    14233      +51     
  Misses       1197     1197              
Impacted Files Coverage Δ
ctapipe/instrument/camera/geometry.py 90.67% <100.00%> (-0.03%) ⬇️
ctapipe/instrument/camera/readout.py 92.75% <100.00%> (+0.10%) ⬆️
ctapipe/instrument/optics.py 90.56% <100.00%> (+0.18%) ⬆️
ctapipe/instrument/telescope.py 86.84% <100.00%> (+0.35%) ⬆️
ctapipe/calib/camera/pedestals.py 95.87% <0.00%> (ø)
ctapipe/io/tests/test_table_loader.py 99.42% <0.00%> (+0.02%) ⬆️
ctapipe/io/tableloader.py 96.52% <0.00%> (+0.59%) ⬆️
ctapipe/core/container.py 89.89% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4272a4b...5cecb1c. Read the comment docs.

@maxnoe maxnoe requested review from kosack and LukasNickel July 1, 2022 17:32
kosack
kosack previously approved these changes Jul 4, 2022
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 4, 2022
LukasNickel
LukasNickel previously approved these changes Jul 4, 2022
@maxnoe maxnoe dismissed stale reviews from LukasNickel and kosack via 5cecb1c July 4, 2022 09:51
@maxnoe maxnoe requested review from kosack and LukasNickel July 4, 2022 12:08
@maxnoe
Copy link
Member Author

maxnoe commented Jul 4, 2022

Sorry, had to fix an issue with the docs build.

@maxnoe maxnoe merged commit e09acbd into master Jul 4, 2022
@maxnoe maxnoe deleted the hash_floats branch July 4, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants