Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify units code in subarray #1950

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Simplify units code in subarray #1950

merged 1 commit into from
Jun 27, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1950 (280e152) into master (cbb01b5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1950   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         191      191           
  Lines       15088    15088           
=======================================
  Hits        13893    13893           
  Misses       1195     1195           
Impacted Files Coverage Δ
ctapipe/instrument/subarray.py 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb01b5...280e152. Read the comment docs.

@LukasNickel
Copy link
Member

Why can we not use pos.to(u.m) directly without the value dance?

@maxnoe
Copy link
Member Author

maxnoe commented Jun 27, 2022

A list of quantities is not the same as an array quantity.

@LukasNickel
Copy link
Member

Right, thx

@maxnoe maxnoe merged commit 1f66d87 into master Jun 27, 2022
@maxnoe maxnoe deleted the tel_pos_simplify branch June 27, 2022 08:43
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants