Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing already opened h5file to table loader #1933

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1933 (e41b8b5) into master (0c628d7) will increase coverage by 0.00%.
The diff coverage is 95.45%.

@@           Coverage Diff           @@
##           master    #1933   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         189      189           
  Lines       14963    14984   +21     
=======================================
+ Hits        13780    13800   +20     
- Misses       1183     1184    +1     
Impacted Files Coverage Δ
ctapipe/io/tests/test_table_loader.py 99.03% <90.90%> (-0.97%) ⬇️
ctapipe/io/tableloader.py 95.54% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c628d7...e41b8b5. Read the comment docs.

@maxnoe maxnoe requested a review from kosack June 14, 2022 11:50
@maxnoe maxnoe merged commit 8325700 into master Jun 15, 2022
@maxnoe maxnoe deleted the table_loader_open_file branch June 15, 2022 10:22
@maxnoe maxnoe changed the title Table loader open file Allow passing already opened h5file to table loader Jul 11, 2022
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants