Refactor/rename data writer options #1920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added tests comparing to using a Frame transform - created alternate implementation for test comparison
- use az -> -az to make azimuth go in the correct direction - spherical_to_cartesian - thanks to Julian S for spotting this!
…nto feature/impact_computation
updated all places where they are used as well
Also issubset was used in the wrong order. Not sure how this worked before...
The array in the test files is:
```
Subarray : MonteCarloArray
Num Tels : 180
Footprint: 4.92 km2
Type Count Tel IDs
----------------- ----- ---------------
LST_LST_LSTCam 4 1-4
MST_MST_NectarCam 28 100-124,128-130
SST_ASTRI_CHEC 120 30-99,131-180
MST_MST_FlashCam 28 5-29,125-127
```
instead of to a separate impact table
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #1920 +/- ##
==========================================
+ Coverage 92.08% 92.12% +0.03%
==========================================
Files 189 191 +2
Lines 14954 15053 +99
==========================================
+ Hits 13771 13868 +97
- Misses 1183 1185 +2
Continue to review full report at Codecov.
|
maxnoe
previously approved these changes
May 25, 2022
kosack
force-pushed
the
refactor/rename_data_writer_options
branch
from
70547c6 to
89f7135
Compare
…nto refactor/rename_data_writer_options
|
I think this would still be nice to have, could you rebase on current main? |
|
Moved to #2520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #1899
rename :