Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting up logging hierarchy, fixes #1882 #1883

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix setting up logging hierarchy, fixes #1882 #1883

merged 2 commits into from
Apr 20, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 19, 2022

No description provided.

@maxnoe maxnoe requested review from kosack and nbiederbeck and removed request for kosack April 19, 2022 16:29
kosack
kosack previously approved these changes Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1883 (067752b) into master (0612a33) will increase coverage by 0.01%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
+ Coverage   92.04%   92.05%   +0.01%     
==========================================
  Files         189      189              
  Lines       14842    14862      +20     
==========================================
+ Hits        13661    13681      +20     
  Misses       1181     1181              
Impacted Files Coverage Δ
ctapipe/core/tests/test_component.py 97.83% <95.00%> (-0.23%) ⬇️
ctapipe/core/component.py 97.64% <100.00%> (+1.17%) ⬆️
ctapipe/core/tool.py 93.39% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0612a33...067752b. Read the comment docs.

@maxnoe
Copy link
Member Author

maxnoe commented Apr 19, 2022

@kosack Sorry, it has to come before super().__init__() to enable using the log in traitlets observers, as it is used in the examples. Remove the self. works though.

@kosack kosack merged commit 82a8809 into master Apr 20, 2022
@maxnoe maxnoe added the bug label Apr 20, 2022
@maxnoe maxnoe added this to the v0.14.1 milestone Apr 20, 2022
@maxnoe maxnoe modified the milestones: v0.15.1, v0.16.0, v0.15.0 Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants