Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a better template for release-drafter #1880

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Apr 14, 2022

Auto-categorizes PRs by topic. Should make releasing a bit nicer.

The template should look similar to what is used in protopipe here:
https://github.com/cta-observatory/protopipe/releases

(though I removed the unicode icons)

Auto-categorizes PRs by topic.
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1880 (396aa17) into master (0612a33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         189      189           
  Lines       14842    14842           
=======================================
  Hits        13661    13661           
  Misses       1181     1181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0612a33...396aa17. Read the comment docs.

@maxnoe
Copy link
Member

maxnoe commented Apr 14, 2022

That means we have to be more careful with applying labels though, right?

Do we first want to maybe go over the once we want to use? Right now, we have a lot

@kosack
Copy link
Contributor Author

kosack commented Apr 14, 2022

That means we have to be more careful with applying labels though, right?

Yes, though you can still edit it afterward, it just helps to organize the changelog.

Do we first want to maybe go over the once we want to use? Right now, we have a lot

I was noticing that when i went through them to make these categories. I think I got it right, but there are a few that are clearly duplicates, and some are "theme" categories (like "calibration", "reconstruction") while others are "change" categories (new functionality, bug).

We could clean them up, or at least rename/recolor some of them. But that shouldn't affect this PR much, except if we rename them.

@kosack
Copy link
Contributor Author

kosack commented Apr 19, 2022

It seems GitHub has also added a minimal version of this same feature. Not sure if it's better than release-drafter or not.
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

@kosack kosack added this to the v0.14.1 milestone Apr 22, 2022
@kosack kosack requested review from maxnoe and LukasNickel April 22, 2022 14:05
@kosack kosack requested a review from maxnoe May 24, 2022 09:51
@kosack
Copy link
Contributor Author

kosack commented May 24, 2022

Can we merge this so we can test it for future releases?

@maxnoe
Copy link
Member

maxnoe commented May 24, 2022

@LukasNickel

@maxnoe maxnoe modified the milestones: v0.15.1, v0.16.0 Jun 2, 2022
@maxnoe maxnoe requested a review from nbiederbeck July 11, 2022 11:12
@maxnoe maxnoe merged commit 0589efc into cta-observatory:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants