Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event type filter to ctapipe-process #1841

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Add event type filter to ctapipe-process #1841

merged 1 commit into from
Mar 15, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Feb 17, 2022

Allows filtering out un-wanted event types form the output.

kosack
kosack previously approved these changes Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1841 (e660fac) into master (9ee0635) will increase coverage by 0.00%.
The diff coverage is 97.56%.

❗ Current head e660fac differs from pull request most recent head ec6092a. Consider uploading reports for the commit ec6092a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1841   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         188      189    +1     
  Lines       15156    15101   -55     
=======================================
- Hits        13971    13921   -50     
+ Misses       1185     1180    -5     
Impacted Files Coverage Δ
ctapipe/tools/process.py 93.10% <80.00%> (-0.80%) ⬇️
ctapipe/utils/__init__.py 100.00% <100.00%> (ø)
ctapipe/utils/event_type_filter.py 100.00% <100.00%> (ø)
ctapipe/utils/tests/test_event_filter.py 100.00% <100.00%> (ø)
ctapipe/io/tableio.py 91.39% <0.00%> (-1.25%) ⬇️
ctapipe/io/datawriter.py 88.81% <0.00%> (-0.08%) ⬇️
ctapipe/io/tests/test_hdf5.py 99.57% <0.00%> (-0.02%) ⬇️
ctapipe/io/tests/test_column_transforms.py
ctapipe/io/hdf5tableio.py 97.03% <0.00%> (+0.06%) ⬆️
ctapipe/io/hdf5eventsource.py 91.57% <0.00%> (+0.08%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee0635...ec6092a. Read the comment docs.

@maxnoe maxnoe requested a review from LukasNickel February 17, 2022 12:28
LukasNickel
LukasNickel previously approved these changes Feb 17, 2022
nbiederbeck
nbiederbeck previously approved these changes Mar 15, 2022
@maxnoe maxnoe dismissed stale reviews from nbiederbeck and LukasNickel via ec6092a March 15, 2022 09:04
@maxnoe maxnoe force-pushed the event_type_filter branch from e660fac to ec6092a Compare March 15, 2022 09:04
@kosack kosack merged commit c3e8f3d into master Mar 15, 2022
@maxnoe maxnoe deleted the event_type_filter branch March 15, 2022 10:02
@maxnoe maxnoe restored the event_type_filter branch July 11, 2022 09:33
@maxnoe maxnoe deleted the event_type_filter branch July 11, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants