Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixel picker for square pixels #1833

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jan 27, 2022

No description provided.

@maxnoe maxnoe force-pushed the fix_square_pixel_picker branch from 47678d3 to 5a517b4 Compare January 27, 2022 17:42
@maxnoe maxnoe linked an issue Jan 27, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1833 (5a517b4) into master (1b525d3) will increase coverage by 0.02%.
The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1833      +/-   ##
==========================================
+ Coverage   91.80%   91.82%   +0.02%     
==========================================
  Files         190      190              
  Lines       15283    15298      +15     
==========================================
+ Hits        14030    14048      +18     
+ Misses       1253     1250       -3     
Impacted Files Coverage Δ
ctapipe/instrument/camera/geometry.py 90.64% <75.00%> (-0.93%) ⬇️
ctapipe/visualization/mpl_camera.py 92.85% <96.00%> (+1.14%) ⬆️
ctapipe/utils/filelock.py 100.00% <0.00%> (+23.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8298be5...5a517b4. Read the comment docs.

@maxnoe maxnoe requested review from kosack and LukasNickel January 27, 2022 20:40
@LukasNickel
Copy link
Member

Why was this done in the first place?
Did (x,y) refer to the pixel edges and not the centers?

@maxnoe
Copy link
Member Author

maxnoe commented Jan 28, 2022

Why was this done in the first place?
Did (x,y) refer to the pixel edges and not the centers?

For the old code using plt.Rectangle, (x, y) refered to the lower left corner. See changes here: #1819

https://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Rectangle.html
https://matplotlib.org/stable/api/_as_gen/matplotlib.patches.RegularPolygon.html

@maxnoe maxnoe merged commit 3e35093 into master Feb 1, 2022
@maxnoe maxnoe deleted the fix_square_pixel_picker branch February 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CameraDisplay's pixel picker broken
3 participants