-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated tools #1827
Remove outdated tools #1827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
+ Coverage 91.68% 92.10% +0.42%
==========================================
Files 190 186 -4
Lines 15004 14902 -102
==========================================
- Hits 13756 13726 -30
+ Misses 1248 1176 -72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I still use some of these for debugging and outreach, I think it's ok to drop them since now with the DL1/DL2 data model + ctapipe.io.TableLoader
+ Jupyter notebooks, it's easy to replicate all of this functionality, and often simpler.
Though I still like camdemo, as it's fun and a nice simple example of writing a Tool and using the InstrumentDescription model! |
Then should I move it to examples? Or the Tool documentation? I am against having something that's just supposed to be a documentation example installed in |
Remove the four tools discussed for removal here #1506