You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pytables based function to write an astropy table
into a hdf5 file using the ctapipe conventions.
This enables writing tables in the same format as used by the
HDF5TableWriter and those tables can be read using read_table.
It also switches SubarrayDescription.to_hdf / from_hdf to use the new
functions, eliminating the mix of astropy table io using h5py and
ctapipe hdf5 table io using pytables.
ctapipe files should now only contain datasets written by tables and
use the same way to store metadata consistently.
By checking for the existence of __table_column_meta__ datasets, we can stay backwards compatible and still read older subarray files.
This now also adds support for reading and writing unicode strings with a max length in utf8 bytes to the hdf io classes and functions.
maxnoe
changed the title
Add write_table and use it in SubarrayDescription.to_hdf
Add write_table and use it in SubarrayDescription.to_hdf, fixes #1449
Jan 3, 2022
maxnoe
linked an issue
Jan 3, 2022
that may be
closed
by this pull request
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just need to clean up some unused imports since now those are mandatory. (related - should we remove Codacy from the list of checks since pyflakes is now run? It's nice for history, but always gives lots of errors)
* This adds a pytables based function to write an astropy table
into a hdf5 file using the ctapipe conventions.
This enables writing tables in the same format as used by the
HDF5TableWriter and those tables can be read using read_table.
* It also switches SubarrayDescription.to_hdf / from_hdf to use the new
functions, eliminating the mix of astropy table io using h5py and
ctapipe hdf5 table io using pytables.
* ctapipe files should now only contain datasets written by tables and
use the same way to store metadata consistently.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxnoe
changed the title
This adds a pytables based function to write an astropy table
into a hdf5 file using the ctapipe conventions.
This enables writing tables in the same format as used by the
HDF5TableWriter and those tables can be read using read_table.
It also switches SubarrayDescription.to_hdf / from_hdf to use the new
functions, eliminating the mix of astropy table io using h5py and
ctapipe hdf5 table io using pytables.
ctapipe files should now only contain datasets written by tables and
use the same way to store metadata consistently.
By checking for the existence of
__table_column_meta__datasets, we can stay backwards compatible and still read older subarray files.This now also adds support for reading and writing unicode strings with a max length in utf8 bytes to the hdf io classes and functions.