Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing FITS in fileinfo for unicode #1789

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 17, 2021

No description provided.

@maxnoe maxnoe linked an issue Sep 17, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #1789 (e19e95f) into master (63e0df4) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
- Coverage   91.80%   91.79%   -0.02%     
==========================================
  Files         188      188              
  Lines       14910    14914       +4     
==========================================
+ Hits        13688    13690       +2     
- Misses       1222     1224       +2     
Impacted Files Coverage Δ
ctapipe/conftest.py 95.41% <ø> (ø)
ctapipe/tools/fileinfo.py 17.64% <0.00%> (-0.73%) ⬇️
ctapipe/tools/tests/test_tools.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e0df4...e19e95f. Read the comment docs.

@kosack kosack merged commit af5018f into master Sep 17, 2021
@kosack kosack deleted the allow_unicode_fileinfo branch September 17, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests fail because my name has non ascii characters
3 participants