Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TelescopeParameter for traitlets 5.1 #1784

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fix TelescopeParameter for traitlets 5.1 #1784

merged 1 commit into from
Sep 1, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Aug 31, 2021

This removal in traitlets seems to be the culprit:

@@ -2644,12 +2638,6 @@ class List(Container):
 
         return super(List, self).validate_elements(obj, value)
 
-    def set(self, obj, value):
-        if isinstance(value, str):
-            return super().set(obj, [value])
-        else:
-            return super().set(obj, value)
-
 

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #1784 (4a0a483) into master (a4b8e54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1784   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         187      187           
  Lines       14827    14829    +2     
=======================================
+ Hits        13618    13620    +2     
  Misses       1209     1209           
Impacted Files Coverage Δ
ctapipe/core/traits.py 95.12% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b8e54...4a0a483. Read the comment docs.

@maxnoe maxnoe requested review from kosack and LukasNickel August 31, 2021 17:20
@maxnoe maxnoe linked an issue Aug 31, 2021 that may be closed by this pull request
@kosack kosack merged commit 1fd747b into master Sep 1, 2021
@maxnoe maxnoe deleted the update_traitlets branch September 1, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing due to new traitlets version
3 participants