Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use sphinx action for building docs #1780

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Do not use sphinx action for building docs #1780

merged 6 commits into from
Aug 30, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Aug 30, 2021

Trying to fix the docs build by not using the sphinx extension.

We loose the automatic PR comments for sphinx warnings though.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1780 (8b37e58) into master (c9cdfc8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1780   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         187      187           
  Lines       14827    14827           
=======================================
  Hits        13618    13618           
  Misses       1209     1209           
Impacted Files Coverage Δ
ctapipe/instrument/camera/geometry.py 91.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cdfc8...8b37e58. Read the comment docs.

@maxnoe
Copy link
Member Author

maxnoe commented Aug 30, 2021

Ok, I think we should merge this to unblock the other PRs, we can switch back to the sphinx action if/when it gets updated.

@maxnoe maxnoe linked an issue Aug 30, 2021 that may be closed by this pull request
@kosack kosack merged commit 5d0945c into master Aug 30, 2021
@maxnoe maxnoe deleted the fix_docs_builds branch August 30, 2021 13:49
LukasNickel pushed a commit that referenced this pull request Aug 31, 2021
* Do not use sphinx action for building docs

* Add setup python step

* Add sudo

* Fix doc build command in CI

* Fix doc sections

* Install graphviz in docs build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc action failing
4 participants