Configurable contact information for DataWriter #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
- Coverage 91.94% 91.84% -0.10%
==========================================
Files 182 182
Lines 14380 14403 +23
==========================================
+ Hits 13221 13228 +7
- Misses 1159 1175 +16
Continue to review full report at Codecov.
|
kosack
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
The only other thing that we could consider is the PROCESS ID and PROCESS SUBTYPE - that is supposed to describe the overall "parent" activity, so the ID could be the MC prod name (which currently is not in the simtel files, so can't be filled automatically), and subtype is not fully defined yet.
LukasNickel
approved these changes
Jul 23, 2021
maxnoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Contact info a configurable trait of the
DataWriterso that users can actually set the proper contact info when running tools.We probably also want to enable this for other metadata fields, but for the others it was not as clear to me which should be autofilled and which should rely on user input.