Add support for calibration scale and shift in R1 #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
- Coverage 91.62% 91.50% -0.12%
==========================================
Files 185 185
Lines 14382 14400 +18
==========================================
Hits 13177 13177
- Misses 1205 1223 +18
Continue to review full report at Codecov.
|
maxnoe
reviewed
Jun 4, 2021
kosack
approved these changes
Jun 4, 2021
7 tasks
kosack
approved these changes
Jun 4, 2021
maxnoe
approved these changes
Jul 5, 2021
nbiederbeck
pushed a commit
to nbiederbeck/ctapipe
that referenced
this pull request
Aug 3, 2021
* Add calib_scale as a traitlet to SimtelEventSource and use it in R0->R1 * Add unit-test * Remove unused CameraCalibrator * fix test assertion * Improve docstring * Add suport for calibration shift in SimtelEventSource * Extend unit-test to test also calibration shift * simplify unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to both scale and shift the R1 waveform samples in photoelectrons from
SimtelEventSource.The scale factor (called
calib_scalein simtel and == 0.92 in both HESS and CTAMARS analyses - possibly depends on prod also) is on top of the already present DC_to_PHE factor, which is now explicit.This is also reported in #1744 .
@moralejo could you check if this corresponds to what you apply in your analysis?
The shift can be useful for simulating a mis-calibration (for example to see how far calibration can drift before we need new IRFs)