Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant test code in simtel event source test code #1747

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 3, 2021

The exact same code is further down in two individual tests.

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #1747 (de8b96e) into master (9fb2901) will decrease coverage by 0.12%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1747      +/-   ##
==========================================
- Coverage   91.62%   91.49%   -0.13%     
==========================================
  Files         185      185              
  Lines       14382    14380       -2     
==========================================
- Hits        13177    13157      -20     
- Misses       1205     1223      +18     
Impacted Files Coverage Δ
ctapipe/io/tests/test_simteleventsource.py 100.00% <ø> (ø)
ctapipe/tools/tests/test_tools.py 97.16% <ø> (ø)
ctapipe/conftest.py 95.41% <94.11%> (-1.62%) ⬇️
ctapipe/io/tests/test_dl1eventsource.py 98.73% <100.00%> (+3.73%) ⬆️
ctapipe/tools/tests/test_merge.py 100.00% <100.00%> (ø)
ctapipe/tools/camdemo.py 55.68% <0.00%> (-20.46%) ⬇️
ctapipe/io/dl1eventsource.py 90.60% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb2901...de8b96e. Read the comment docs.

@maxnoe maxnoe requested a review from LukasNickel July 2, 2021 15:54
@maxnoe maxnoe merged commit a043d43 into master Jul 2, 2021
@maxnoe maxnoe deleted the remove_duplicated_test_code branch July 2, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants