Use .ecsv extension in dump instrument to enable Table.read.

[maxnoe]

When using .ecsv, astropy table automatically chooses the ascii.ecsv format, also when reading.

By using .ecsv.txt we prevent simply usung Table.read(path)

[kosack]

The reason for adding .txt was just so that when clicking the file in Linux/macOS/Windows, a text editor or viewer is able to open it (rather than nothing, since ecsv is not a well known format is not registered by default). It also makes QuickLook (in macOS) or Sushi (gnome linux) work, so you can preview the file in a file manager.

But yes, it is nice if astropy can detect it. It's too bad it does that by extension, not magic number or header

[maxnoe]

MMh, on my system that's not an issue with the ecsv extension:

❯ file MonteCarloArray.optics.ecsv
MonteCarloArray.optics.ecsv: ASCII text

And xdg-open MonteCarloArray.optics.ecsv opens the file in my default text editor.

[codecov]

Codecov Report

Merging #1722 (7a22201) into master (996c048) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1722   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         190      190           
  Lines       15255    15255           
=======================================
  Hits        14008    14008           
  Misses       1247     1247           

Impacted Files	Coverage Δ
ctapipe/tools/dump_instrument.py	87.95% <100.00%> (ø)
ctapipe/tools/tests/test_tools.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996c048...7a22201. Read the comment docs.

[kosack]

Yeah, seems to work now, so I'm ok with the change.