Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortform aliases #1713

Merged
merged 2 commits into from
May 12, 2021
Merged

Shortform aliases #1713

merged 2 commits into from
May 12, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 11, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1713 (82c4abe) into master (b4d1e29) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   90.75%   90.77%   +0.02%     
==========================================
  Files         183      183              
  Lines       14151    14182      +31     
==========================================
+ Hits        12843    12874      +31     
  Misses       1308     1308              
Impacted Files Coverage Δ
ctapipe/tools/stage1.py 97.91% <ø> (ø)
ctapipe/core/tool.py 93.15% <100.00%> (ø)
ctapipe/image/muon/fitting.py 100.00% <0.00%> (ø)
ctapipe/image/muon/intensity_fitter.py 89.40% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d1e29...82c4abe. Read the comment docs.

@nbiederbeck
Copy link
Contributor

nbiederbeck commented May 11, 2021

-p is used in the MergeTool as a short form for pattern. I'm a big fan of consistency, so should we (I) change it there (to -p/--progress) before we merge #1712?

@maxnoe
Copy link
Member Author

maxnoe commented May 11, 2021

Good catch. No, let's just go ahead with #1712 and I'll do a check for consistency here.

@maxnoe maxnoe added this to the v0.12.0 milestone May 11, 2021
kosack
kosack previously approved these changes May 11, 2021
@maxnoe
Copy link
Member Author

maxnoe commented May 11, 2021

I removed the -p shortform for progress for now.

@kosack kosack merged commit a68e357 into master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants