Raise error in CameraReadout.from_name if no corresponding file can be found #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 90.70% 90.69% -0.02%
==========================================
Files 183 183
Lines 14082 14084 +2
==========================================
Hits 12773 12773
- Misses 1309 1311 +2
Continue to review full report at Codecov.
|
nbiederbeck
reviewed
May 7, 2021
| reference_pulse_sample_width=u.Quantity(1, u.ns), | ||
| ) | ||
| tabname = "{camera_name}{verstr}.camreadout".format( | ||
| camera_name=camera_name, verstr=verstr |
There was a problem hiding this comment.
maybe use f-string syntax?
There was a problem hiding this comment.
I didn't add/change this code, just removed a try except around. There is no real reason to remove format
nbiederbeck
approved these changes
May 7, 2021
LukasNickel
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readoutto None inCameraDescription.from_nameif that exception is raised.