Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version of ctapipe-extra directory to v0.3.2 #1588

Merged
merged 5 commits into from
Feb 3, 2021
Merged

bump version of ctapipe-extra directory to v0.3.2 #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54e8baf
bump version of ctapipe-extra directory to v0.3.2
kosack Feb 2, 2021
1a9e357
update test for data volume reducer
kosack Feb 2, 2021
b2b915b
switch back to NeighborPeak in test, but add window shift
kosack Feb 2, 2021
5c36364
update concentration test
kosack Feb 2, 2021
ce1be58
increase test image intensity
kosack Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ctapipe/image/tests/test_concentration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_concentration():
conc = concentration_parameters(geom, image, hillas)

assert 0.1 <= conc.cog <= 0.3
assert 0.05 <= conc.pixel <= 0.2
assert 0.04 <= conc.pixel <= 0.2
assert 0.3 <= conc.core <= 0.6


Expand Down
4 changes: 4 additions & 0 deletions ctapipe/image/tests/test_reducer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ def test_tailcuts_data_volume_reducer(subarray_lst):
"keep_isolated_pixels": True,
},
"image_extractor_type": "NeighborPeakWindowSum",
"NeighborPeakWindowSum": {
"apply_integration_correction": False,
"window_shift": 0,
},
"n_end_dilates": 1,
"do_boundary_dilation": True,
}
Expand Down
8 changes: 3 additions & 5 deletions ctapipe/image/tests/test_toy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ def test_intensity():
x, y = u.Quantity([0.2, 0.3], u.m)
width = 0.05 * u.m
length = 0.15 * u.m
intensity = 50
intensity = 200
psi = "30d"

# make a toymodel shower model
model = Gaussian(x=x, y=y, width=width, length=length, psi=psi)

_, signal, _ = model.generate_image(geom, intensity=intensity, nsb_level_pe=5,)
_, signal, _ = model.generate_image(geom, intensity=intensity, nsb_level_pe=5)

# test if signal reproduces given cog values
assert np.average(geom.pix_x.to_value(u.m), weights=signal) == approx(0.2, rel=0.15)
Expand Down Expand Up @@ -56,9 +56,7 @@ def test_skewed():
model = SkewedGaussian(
x=x, y=y, width=width, length=length, psi=psi, skewness=skewness
)
model.generate_image(
geom, intensity=intensity, nsb_level_pe=5,
)
model.generate_image(geom, intensity=intensity, nsb_level_pe=5)

a, loc, scale = model._moments_to_parameters()
mean, var, skew = skewnorm(a=a, loc=loc, scale=scale).stats(moments="mvs")
Expand Down
2 changes: 1 addition & 1 deletion ctapipe/utils/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
__all__ = ["get_dataset_path", "find_in_path", "find_all_matching_datasets"]


DEFAULT_URL = "http://cccta-dataserver.in2p3.fr/data/ctapipe-extra/v0.3.1/"
DEFAULT_URL = "http://cccta-dataserver.in2p3.fr/data/ctapipe-extra/v0.3.2/"


def get_searchpath_dirs(searchpath=os.getenv("CTAPIPE_SVC_PATH")):
Expand Down