Simplify pixel log-likelihood. #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify the log-likelihood analytically * discard constants and factors which are not needed in minimization
|
Yes, just use this function in the muon code |
kosack
reviewed
Aug 3, 2020
Reference was already there, so use correct link and remove reference section in this docstring.
|
Could you also apply the same treatment to the other functions and then use the right one in the muon code? |
yes |
added 8 commits
August 17, 2020 11:47
* Due to likelihoods returning floats not arrays, calculate numeric and approximation, then sum both
nbiederbeck
changed the title
kosack
previously approved these changes
Aug 17, 2020
|
@nbiederbeck Tests are failing due to an import error. Somewhere, probably it still imports one of the older names. There is also a merge conflict now |
* change names * use numpy arrays * use sum, because we calculate telescope-likelihood not pixel-likelihood
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
+ Coverage 90.90% 91.27% +0.37%
==========================================
Files 184 184
Lines 12882 12861 -21
==========================================
+ Hits 11710 11739 +29
+ Misses 1172 1122 -50
Continue to review full report at Codecov.
|
maxnoe
reviewed
Sep 15, 2020
* also black fixes that were somehow skipped earlier
kosack
requested changes
Sep 16, 2020
kosack
approved these changes
Sep 21, 2020
maxnoe
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the attempt to work on #1272:
but now the function
ctapipe.image.pixel_likelihood.poisson_likelihood_gaussianis basically the same asctapipe.image.muon.intensity_fitter.negative_log_likelihoodin #1390 and duplicate code is not good.Maybe do smth like
ctapipe.image.pixel_likelihood.negative_log_likelihoodand use this in the Muon and ImPACT fitting?