Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer hdftable #1089

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Integer hdftable #1089

merged 2 commits into from
Jun 18, 2019

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 18, 2019

Python ints were stored as 32 bit, which is unfortunate as they are unlimited precision ints and there is no overflow warning issued.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1089 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   84.33%   84.35%   +0.02%     
==========================================
  Files         182      182              
  Lines       11041    11056      +15     
==========================================
+ Hits         9311     9326      +15     
  Misses       1730     1730
Impacted Files Coverage Δ
ctapipe/io/hdf5tableio.py 93.49% <ø> (ø) ⬆️
ctapipe/io/tests/test_hdf5.py 97.59% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb9995...a5aa575. Read the comment docs.

@maxnoe maxnoe merged commit a87947f into master Jun 18, 2019
@maxnoe maxnoe deleted the integer_hdftable branch June 18, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants