-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken telescope id string, Fixes #1058 #1069
Merged
kosack
merged 15 commits into
cta-observatory:master
from
kosack:fix/broken_telescope_id_string
May 20, 2019
Merged
Fix broken telescope id string, Fixes #1058 #1069
kosack
merged 15 commits into
cta-observatory:master
from
kosack:fix/broken_telescope_id_string
May 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get_tel_ids_for_type() was broken due to change in string representation, it is now fixed. - added many unit tests to prevent regression
maxnoe
reviewed
May 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
+ Coverage 83.44% 83.56% +0.11%
==========================================
Files 181 181
Lines 10439 10494 +55
==========================================
+ Hits 8711 8769 +58
+ Misses 1728 1725 -3
Continue to review full report at Codecov.
|
watsonjj
approved these changes
May 20, 2019
maxnoe
approved these changes
May 20, 2019
kbruegge
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE_OPTICS_CAMERA
(usable as an output file or group name)SubarrayDescription.get_tel_ids_for_type()
was broken due to the previous name change, this fixes it