Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken telescope id string, Fixes #1058 #1069

Merged
merged 15 commits into from
May 20, 2019

Conversation

kosack
Copy link
Contributor

@kosack kosack commented May 10, 2019

  • telescope names are now normalized to TYPE_OPTICS_CAMERA (usable as an output file or group name)
  • SubarrayDescription.get_tel_ids_for_type() was broken due to the previous name change, this fixes it
  • added a lot of unit tests to prevent regression
  • added a function and property to map telescope IDs to telescope indices (useful for creating things like trigger patterns or packing telescope data)

kosack added 5 commits May 10, 2019 14:31
- get_tel_ids_for_type() was broken due to change in string representation, it is now fixed.
- added many unit tests to prevent regression
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1069 into master will increase coverage by 0.11%.
The diff coverage is 97.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
+ Coverage   83.44%   83.56%   +0.11%     
==========================================
  Files         181      181              
  Lines       10439    10494      +55     
==========================================
+ Hits         8711     8769      +58     
+ Misses       1728     1725       -3
Impacted Files Coverage Δ
ctapipe/instrument/tests/test_camera.py 100% <100%> (ø) ⬆️
ctapipe/instrument/tests/test_subarray.py 100% <100%> (+2.77%) ⬆️
ctapipe/instrument/guess.py 100% <100%> (ø) ⬆️
ctapipe/io/hessioeventsource.py 92.8% <100%> (ø) ⬆️
ctapipe/instrument/tests/test_telescope.py 100% <100%> (ø) ⬆️
ctapipe/io/simteleventsource.py 98.46% <100%> (ø) ⬆️
ctapipe/instrument/tests/test_optics.py 100% <100%> (ø) ⬆️
ctapipe/image/muon/muon_reco_functions.py 66.66% <100%> (ø) ⬆️
ctapipe/instrument/telescope.py 96% <90.9%> (+0.54%) ⬆️
ctapipe/instrument/optics.py 94.28% <92.3%> (+2.85%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea8a57...288cf4e. Read the comment docs.

@kosack kosack merged commit 2efcfa0 into cta-observatory:master May 20, 2019
@kosack kosack deleted the fix/broken_telescope_id_string branch May 20, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants