Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize index column name in subarray table #1065

Merged
merged 4 commits into from
May 7, 2019

Conversation

kosack
Copy link
Contributor

@kosack kosack commented May 2, 2019

Just a simple change suggested in #1059 to change the column 'id' in the output of SubarrayDescription.to_table() to be tel_id

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #1065 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   83.27%   83.41%   +0.14%     
==========================================
  Files         181      181              
  Lines       10415    10416       +1     
==========================================
+ Hits         8673     8689      +16     
+ Misses       1742     1727      -15
Impacted Files Coverage Δ
ctapipe/instrument/tests/test_subarray.py 97.22% <100%> (+0.07%) ⬆️
ctapipe/instrument/subarray.py 94.94% <100%> (+15.15%) ⬆️
ctapipe/tools/display_summed_images.py 91.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e542ebb...42721ce. Read the comment docs.

Copy link

@thomasgas thomasgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't have to be changed anywhere else, I'm fine.

@kosack kosack merged commit fea8a57 into cta-observatory:master May 7, 2019
@kosack kosack deleted the normalize_subarray_col_names branch May 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants