Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing config to CameraCalibrator #1042

Merged
merged 3 commits into from
Apr 9, 2019

Conversation

watsonjj
Copy link
Contributor

@watsonjj watsonjj commented Apr 8, 2019

Passing a config to CameraCalibrator currently raises the error:

ValueError: Only one of `config` or `parent` allowed If you create a Component as part of another, give `parent=self` and not `config`

This PR fixes that.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1042 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   83.45%   83.47%   +0.01%     
==========================================
  Files         186      186              
  Lines       10531    10539       +8     
==========================================
+ Hits         8789     8797       +8     
  Misses       1742     1742
Impacted Files Coverage Δ
ctapipe/calib/camera/calibrator.py 100% <ø> (ø) ⬆️
ctapipe/calib/camera/tests/test_calibrator.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a243b2...1c7d703. Read the comment docs.

@watsonjj watsonjj merged commit 78208d1 into cta-observatory:master Apr 9, 2019
@watsonjj watsonjj deleted the camera_calibrator branch April 29, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants