Add tests to Tools to check that help message works #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 83.28% 83.35% +0.06%
==========================================
Files 189 189
Lines 10643 10669 +26
==========================================
+ Hits 8864 8893 +29
+ Misses 1779 1776 -3
Continue to review full report at Codecov.
|
maxnoe
approved these changes
Mar 27, 2019
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Mar 27, 2019
* master: Add tests to Tools to check that help message works (cta-observatory#1034) make codacy happy Fix neighbors (cta-observatory#1015) Fix component docs (cta-observatory#1016) related to cta-observatory#1013 allow enums in containers and support in tableio # Conflicts: # ctapipe/tools/bokeh/file_viewer.py # ctapipe/tools/extract_charge_resolution.py
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Mar 28, 2019
* master: Corrections to address comments Add tests to Tools to check that help message works (cta-observatory#1034) make codacy happy Fix neighbors (cta-observatory#1015) Fix component docs (cta-observatory#1016) related to cta-observatory#1013 allow enums in containers and support in tableio
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Mar 29, 2019
* master: Corrections to address comments Add tests to Tools to check that help message works (cta-observatory#1034) make codacy happy Fix neighbors (cta-observatory#1015) Fix component docs (cta-observatory#1016) related to cta-observatory#1013 allow enums in containers and support in tableio # Conflicts: # ctapipe/image/tests/test_charge_extraction.py # ctapipe/image/waveform_extractor.py # ctapipe/tools/extract_charge_resolution.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors are raised when trying to print the help message if there is a traitlet mismatch between the Tool aliases, and the components. This was not previously tested for.