Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChargeExtractor tests and simplification #1023

Merged
merged 14 commits into from
Mar 28, 2019
Merged

ChargeExtractor tests and simplification #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5403cbe
Remove dependency on example_event (from ctapipe_extra)
watsonjj Mar 21, 2019
89bfbf4
Add checks for values to ensure behaviour is kept for upcoming changes
watsonjj Mar 21, 2019
3834bc7
Make hi and lo gain channels contain truly different waveforms for th…
watsonjj Mar 22, 2019
d5d023a
Move lo gain waveforms to a different part of the wf to really distin…
watsonjj Mar 22, 2019
f56dec1
Simplify structure of the charge_extractor module
watsonjj Mar 22, 2019
689cec9
Fixes for tests
watsonjj Mar 22, 2019
cbbf0bd
Fix codacy complaints
watsonjj Mar 22, 2019
75c46bc
Restore SimpleIntegrator docstring
watsonjj Mar 23, 2019
3db7781
Replace masked array usage in extract_charge_from_peakpos_array
watsonjj Mar 25, 2019
2a05cb0
Create abstract classes for easier traitlet configuration
watsonjj Mar 25, 2019
3193e7c
Fixes for tools
watsonjj Mar 25, 2019
fea6b35
Adopted suggestion for configuration discussed in #1029
watsonjj Mar 26, 2019
15ad53b
Corrections to address comments
watsonjj Mar 27, 2019
5baf334
Merge branch 'master' into charge_extractor
watsonjj Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading