Set defaults only for fields not passed in __init__ #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 80.26% 80.42% +0.16%
==========================================
Files 193 193
Lines 11045 11045
==========================================
+ Hits 8865 8883 +18
+ Misses 2180 2162 -18
Continue to review full report at Codecov.
|
maxnoe
force-pushed
the
container_defaults
branch
from
bbae820 to
fac99cf
Compare
kosack
approved these changes
Mar 5, 2019
dneise
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces runtime if values are passed to
__init__quite a bit for simple cases. If defaults are large, the speedup should be even more prominent.