Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HillasParameterContainer should be filled with np.nan if higher moments are not calculated #742

Closed
maxnoe opened this issue May 16, 2018 · 0 comments
Closed

HillasParameterContainer should be filled with np.nan if higher moments are not calculated #742

maxnoe opened this issue May 16, 2018 · 0 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented May 16, 2018

0.0 are valid values for these variables, so should not be used in case no value was ever calculated.
@STSpencer STSpencer mentioned this issue May 18, 2018
Merged
kosack pushed a commit that referenced this issue Jun 18, 2018
@STSpencer @kosack
Change requested in #742: init Hillas skewness and kurtosis to NaN (#744
2a629c9 
)

* Initialize higher order Hillas parameters to nan such that they are not accidentally set to zero if not calculated

* Set all hillas to nan

* Set high order hillas parameters to nan if not calculated

* Made first hillas parameter method consistent with the others with respect to high order calculations

* Made requested changes to nan placement and removed direct float comparisons
@kosack kosack closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxnoe @kosack