-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scipy rotation matrices instead of by hand transformation #2097
Labels
Comments
Does that support broadcasting many angles? That wa sthe problem the last time I tried to simplify that code. |
The documentation says: |
|
But has to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this would be easier to read if we use something like
R.from_rotvec(vec).as_matrix()
from scipy.ctapipe/ctapipe/coordinates/ground_frames.py
Lines 112 to 124 in 5de39ce
The text was updated successfully, but these errors were encountered: