Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDF5EventSource does not support dl2-only files #2058

Closed
LukasNickel opened this issue Aug 22, 2022 · 0 comments
Closed

HDF5EventSource does not support dl2-only files #2058

LukasNickel opened this issue Aug 22, 2022 · 0 comments
Assignees
@LukasNickel
Labels
bug

Comments

@LukasNickel
Copy link
Member

Describe the bug
If no dl1 information is written in the file (neither images nor parameters), the hdf5eventsource will claim to not be compatible.

To Reproduce
Steps to reproduce the behavior:

  1. Create dl2 files with write_images and write_parameters set to false, but write showers to True
  2. Try to merge the files (it checks for compatible sources to see if the file is valid)

Expected behavior
The dl2 information should be filled.

Supporting information

ctapipe/ctapipe/io/hdf5eventsource.py

Lines 218 to 219 in 0214776

if not datalevels.intersection(("R1", "DL1_IMAGES", "DL1_PARAMETERS")):
return False

@LukasNickel LukasNickel self-assigned this Aug 22, 2022
LukasNickel added a commit that referenced this issue Aug 22, 2022
@LukasNickel
Report HDF5EventSource as compatible for dl2 only files, fixes #2058
0105529 
- Files with no dl1 information are now compatible if there is dl2
  information in the file. This matters for the case of
  --no-write-images and no-write-parameters or if they are skipped during
  the merge step
- Adds dl2 only file to conftest and checks compatibility
@kosack kosack closed this as completed in b50c538 Aug 25, 2022
LukasBeiske pushed a commit to LukasBeiske/ctapipe that referenced this issue Sep 8, 2022
@LukasNickel @LukasBeiske
Report HDF5EventSource as compatible for dl2 only files, fixes cta-ob…
f6120f1 
…servatory#2058 (cta-observatory#2059)

* Report HDF5EventSource as compatible for dl2 only files, fixes cta-observatory#2058

- Files with no dl1 information are now compatible if there is dl2
  information in the file. This matters for the case of
  --no-write-images and no-write-parameters or if they are skipped during
  the merge step
- Adds dl2 only file to conftest and checks compatibility

* Split is_compatible test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasNickel LukasNickel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasNickel