-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact-distance is stored for all telescopes #1961
Labels
Comments
LukasNickel
added a commit
that referenced
this issue
Jun 27, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available
LukasNickel
added a commit
that referenced
this issue
Jun 27, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
Merged
I just also ran into this. I agree, we should only store the triggered telescpoes, as this is an invariance assumed by the hdf5 table reader. |
maxnoe
added a commit
that referenced
this issue
Jun 27, 2022
maxnoe
added a commit
that referenced
this issue
Jun 27, 2022
maxnoe
added a commit
that referenced
this issue
Jun 27, 2022
kosack
changed the title
Impact reconstructor stores distance for all telescopes
Impact-distance is stored for all telescopes
Jun 28, 2022
maxnoe
pushed a commit
that referenced
this issue
Jul 4, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Jul 4, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
nbiederbeck
added a commit
that referenced
this issue
Jul 25, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
nbiederbeck
added a commit
that referenced
this issue
Jul 28, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Sep 8, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Sep 21, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Sep 23, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Sep 29, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Oct 20, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Oct 27, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe
pushed a commit
that referenced
this issue
Oct 28, 2022
- Files with the impact reconstructor applied have a differing amount of tables in the dl1 and the dl2 group. See #1961 for details. This breaks the unit tests as it tries to apply the model to telescopes without dl1 information available Co-authored-by: Noah Biederbeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Impact reconstructor stores distance for all telescopes in a subarray independent of if they triggered or not.
This can lead to situations where the dl1 table of a telescope is empty, but the dl2 table contains (useless) impact distances, which leads to confusing behaviour of the tableloader (Columns missing from the table, but no error).
Expected behavior
I expect only distances to triggered telescopes to be written.
Supporting information
ctapipe/ctapipe/reco/shower_processor.py
Lines 81 to 89 in 27e5439
Additional context
It mostly matters for small files, but our dl2 geometry file is such a candidate:
The text was updated successfully, but these errors were encountered: