Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact-distance is stored for all telescopes #1961

Closed
LukasNickel opened this issue Jun 27, 2022 · 1 comment
Closed

Impact-distance is stored for all telescopes #1961

LukasNickel opened this issue Jun 27, 2022 · 1 comment
Labels

Comments

@LukasNickel
Copy link
Member

Describe the bug
Impact reconstructor stores distance for all telescopes in a subarray independent of if they triggered or not.
This can lead to situations where the dl1 table of a telescope is empty, but the dl2 table contains (useless) impact distances, which leads to confusing behaviour of the tableloader (Columns missing from the table, but no error).

Expected behavior
I expect only distances to triggered telescopes to be written.

Supporting information

impact_distances = shower_impact_distance(
shower_geom=event.dl2.stereo.geometry[k], subarray=self.subarray
)
for tel_index, impact_distance in enumerate(impact_distances):
tel_id = self.subarray.tel_ids[tel_index]
event.dl2.tel[tel_id].impact[k] = TelescopeImpactParameterContainer(
distance=impact_distance
)

Additional context
It mostly matters for small files, but our dl2 geometry file is such a candidate:

Screenshot_2022-06-27_17-20-22

LukasNickel added a commit that referenced this issue Jun 27, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available
LukasNickel added a commit that referenced this issue Jun 27, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
@maxnoe
Copy link
Member

maxnoe commented Jun 27, 2022

I just also ran into this. I agree, we should only store the triggered telescpoes, as this is an invariance assumed by the hdf5 table reader.

maxnoe added a commit that referenced this issue Jun 27, 2022
maxnoe added a commit that referenced this issue Jun 27, 2022
@kosack kosack changed the title Impact reconstructor stores distance for all telescopes Impact-distance is stored for all telescopes Jun 28, 2022
@kosack kosack closed this as completed in 8c24857 Jun 28, 2022
maxnoe pushed a commit that referenced this issue Jul 4, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe added a commit that referenced this issue Jul 4, 2022
maxnoe pushed a commit that referenced this issue Jul 4, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
nbiederbeck added a commit that referenced this issue Jul 25, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
nbiederbeck added a commit that referenced this issue Jul 28, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Sep 8, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Sep 21, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Sep 23, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Sep 29, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Oct 20, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Oct 27, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
maxnoe pushed a commit that referenced this issue Oct 28, 2022
- Files with the impact reconstructor applied have a differing amount of
  tables in the dl1 and the dl2 group. See #1961 for details. This
  breaks the unit tests as it tries to apply the model to telescopes without
  dl1 information available

Co-authored-by: Noah Biederbeck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants