Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib 3.5 breaks some code #1805

Closed
kosack opened this issue Nov 16, 2021 · 5 comments · Fixed by #1807
Closed

matplotlib 3.5 breaks some code #1805

kosack opened this issue Nov 16, 2021 · 5 comments · Fixed by #1807

Comments

@kosack
Copy link
Contributor

kosack commented Nov 16, 2021

We can either:

  1. for now fix the version to 3.4
  2. update the code (preferred)

Main issue seems to be a ValueError: Invalid vmin or vmax when changing a CameraDisplay to log scale.

@HealthyPear
Copy link
Member

If it's a small thing like this I also vote for just fix it and support the newer release

@kosack
Copy link
Contributor Author

kosack commented Nov 16, 2021

I can't seem to reproduce it...

> ctapipe-info --dependencies

*** ctapipe core dependencies ***

             astropy -- 4.3.1
             eventio -- 1.5.1.post1
             iminuit -- 2.7.0
          matplotlib -- 3.5.0
               numba -- 0.54.1
               numpy -- 1.20.3
              pytest -- 6.2.4
               scipy -- 1.7.1
             sklearn -- 1.0.1
              tables -- 3.6.1
           traitlets -- 5.1.1

*** ctapipe optional dependencies ***

   ctapipe_resources -- not installed
            graphviz -- not installed
          matplotlib -- 3.5.0
              pytest -- 6.2.4
> pytest -q ctapipe/visualization/
======================================================= test session starts ========================================================
platform darwin -- Python 3.8.12, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/kkosack/Projects/CTA/Working/ctapipe, configfile: setup.cfg
plugins: cov-2.12.1
collected 17 items

ctapipe/visualization/tests/test_bokeh.py .........                                                                          [ 52%]
ctapipe/visualization/tests/test_mpl.py ........                                                                             [100%]

======================================================== 17 passed in 7.44s ========================================================

@maxnoe
Copy link
Member

maxnoe commented Nov 16, 2021

I can and I have the fix

@kosack
Copy link
Contributor Author

kosack commented Nov 16, 2021

Ok great - maybe it's an interaction with some other dependency? Somehow it works fine for me.

@maxnoe
Copy link
Member

maxnoe commented Nov 16, 2021

For me it was clearly (and rightly) complaining about negative values for the LogNorm

@maxnoe maxnoe linked a pull request Nov 16, 2021 that will close this issue
maxnoe added a commit that referenced this issue Nov 16, 2021
 Fix negative vmin/vmax raising error with mpl3.5, fixes #1805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants