Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master is now failing due to a doctest #1764

Closed
kosack opened this issue Jul 26, 2021 · 1 comment · Fixed by #1765
Closed

master is now failing due to a doctest #1764

kosack opened this issue Jul 26, 2021 · 1 comment · Fixed by #1765

Comments

@kosack
Copy link
Contributor

kosack commented Jul 26, 2021

The doctest in SimTelEventSource is causing the following failure (not sure why it didn't happen in the PR version):

[gw1] linux -- Python 3.8.10 /usr/share/miniconda/envs/ci/bin/python
022     To create an instance of an EventSeeker you must provide it a sub-class of
023     `~ctapipe.io.EventSource` (such as `ctapipe.io.SimTelEventSource`),
024     which will be used to loop through the file and provide the event container,
025     filled with the event information using the methods defined in the
026     event_source for that file format.
027 
028     To obtain a particular event in a simtel file:
029 
030     >>> from ctapipe.io import SimTelEventSource
031     >>> event_source = SimTelEventSource(input_url="dataset://gamma_test_large.simtel.gz")
Expected nothing
Got:
    SIMTEL INIT dataset://gamma_test_large.simtel.gz

/home/runner/work/ctapipe/ctapipe/ctapipe/io/eventseeker.py:31: DocTestFailure

Probably just needs to be changed to an Example section, rather than a doctest. Though I cannot find where the text "SIMTEL INIT" is coming from.

@maxnoe
Copy link
Member

maxnoe commented Jul 26, 2021

sorry, my bad, that's a debug print still in there.

❯ rg 'SIMTEL INIT'
ctapipe/io/simteleventsource.py
232:        print("SIMTEL INIT", input_url)

maxnoe added a commit that referenced this issue Jul 26, 2021
@maxnoe maxnoe linked a pull request Jul 26, 2021 that will close this issue
maxnoe added a commit that referenced this issue Jul 27, 2021
nbiederbeck pushed a commit to nbiederbeck/ctapipe that referenced this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants