move impact parameter computation to Reconstructor

ctapipe/reco/hillas_intersection.py

@@ -118,6 +118,8 @@ def __call__(self, event):
             hillas_dict, array_pointing, telescope_pointings
         )
 
+        self._store_impact_parameter(event)
+
     def _predict(self, hillas_dict, array_pointing, telescopes_pointings=None):
         """
 

ctapipe/reco/hillas_reconstructor.py

@@ -214,6 +214,8 @@ def __call__(self, event):
             event, hillas_dict, array_pointing, telescope_pointings
         )
 
+        self._store_impact_parameter(event)
+
     def _predict(self, event, hillas_dict, array_pointing, telescopes_pointings):
         """
         The function you want to call for the reconstruction of the

ctapipe/reco/reco_algorithms.py

@@ -3,10 +3,12 @@
 import numpy as np
 from astropy.coordinates import AltAz, SkyCoord
 
-from ctapipe.containers import ArrayEventContainer
+from ctapipe.containers import ArrayEventContainer, TelescopeImpactParameterContainer
 from ctapipe.core import Component, QualityQuery
 from ctapipe.core.traits import List
 
+from .impact_distance import shower_impact_distance
+
 __all__ = ["Reconstructor", "TooFewTelescopesException", "InvalidWidthException"]
 
 
@@ -52,7 +54,6 @@ def __call__(self, event: ArrayEventContainer):
         ----------
         tels_dict : dict
             general dictionary containing all triggered telescopes data
-
         Returns
         -------
         None
@@ -93,3 +94,18 @@ def _get_telescope_pointings(event):
             )
             for tel_id in event.dl1.tel.keys()
         }
+
+    def _store_impact_parameter(self, event):
+        """Compute and store the impact parameter for each reconstruction."""
+        impact_distances = shower_impact_distance(
+            shower_geom=event.dl2.stereo.geometry[self.__class__.__name__],
+            subarray=self.subarray,
+        )
+        for tel_id in event.trigger.tels_with_trigger:
+            tel_index = self.subarray.tel_indices[tel_id]
+            event.dl2.tel[tel_id].impact[
+                self.__class__.__name__
+            ] = TelescopeImpactParameterContainer(
+                distance=impact_distances[tel_index],
+                prefix=f"{self.__class__.__name__}_tel",
+            )

ctapipe/reco/shower_processor.py

@@ -7,12 +7,11 @@
 - estimation of classification (optional, currently unavailable)
 
 """
-from ..containers import ArrayEventContainer, TelescopeImpactParameterContainer
+from ..containers import ArrayEventContainer
 from ..core import Component
 from ..core.traits import List, create_class_enum_trait
 from ..instrument import SubarrayDescription
 from . import Reconstructor
-from .impact_distance import shower_impact_distance
 
 
 class ShowerProcessor(Component):
@@ -80,19 +79,3 @@ def __call__(self, event: ArrayEventContainer):
             self.reconstructor_types, self.reconstructors
         ):
             reconstructor(event)
-
-            # compute and store the impact parameter for each reconstruction
-
-            # for the stereo reconstructor:
-            impact_distances = shower_impact_distance(
-                shower_geom=event.dl2.stereo.geometry[reco_type], subarray=self.subarray
-            )
-
-            for tel_id in event.trigger.tels_with_trigger:
-                tel_index = self.subarray.tel_indices[tel_id]
-                event.dl2.tel[tel_id].impact[
-                    reco_type
-                ] = TelescopeImpactParameterContainer(
-                    distance=impact_distances[tel_index],
-                    prefix=f"{reco_type}_tel",
-                )

ctapipe/reco/tests/test_hillas_intersection.py

@@ -240,6 +240,9 @@ def test_selected_subarray(subarray_and_event_gamma_off_axis_500_gev):
     for tel_id in subarray.tel.keys():
         if tel_id not in allowed_tels:
             event.dl1.tel.pop(tel_id, None)
+            event.trigger.tels_with_trigger = event.trigger.tels_with_trigger[
+                event.trigger.tels_with_trigger != tel_id
+            ]
 
     subarray = subarray.select_subarray(allowed_tels)