Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using log in names when necessary #194

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Using log in names when necessary #194

merged 1 commit into from
Oct 18, 2019

Conversation

vuillaut
Copy link
Member

  • add log_mc_energy, log_reco_energy and log_intensity for clarity for the user (corresponds to previous mc_energy, reco_energy and intensity respectively)
  • keep mc_energy and reco_energy in TeV
  • keep intensity in linear scale

@vuillaut
renaming mc_energy by log_mc_energy and reco_energy by log_reco_energ…
c761a26 
…y and intensity by log_intensity for clarity
rlopezcoto
rlopezcoto reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks good to me, I've seen a -3 down there that I guess comes from transforming TeV to GeV. We need very badly to be compliance with astropy units...

@vuillaut
Copy link
Member Author

vuillaut commented Oct 18, 2019 •
edited
Loading

I've seen a -3 down there that I guess comes from transforming TeV to GeV.

Yes I kept the log_energy in log(E/GeV) as it was.

We need very badly to be compliance with astropy units...

I completely agree, it has been on the todo-list for a long time now...

@rlopezcoto rlopezcoto merged commit 5f4710a into cta-observatory:master Oct 18, 2019
@vuillaut vuillaut deleted the var_names branch October 18, 2019 07:26
@vuillaut vuillaut mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlopezcoto rlopezcoto rlopezcoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuillaut @rlopezcoto