-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding simulation info to DL1 files #141
Conversation
This will allow to go further and e.g. avoid requiring simtel files for the sensitivity calculation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas! I'm taking a look at the format and dl1 seems to be fine, I could read the mc data without problem. However, I ran lst-recopipe to check how the format is inherited in the dl2 file and I'm finding a weird structure. When I walk through the groups of the dl2 file like this:
f1 = tables.open_file(dl2_file)
for group in f1.walk_groups():
print(group)
I obtain this list:
/ (RootGroup) ''
/events (Group) ''
/simulation (Group) ''
/events/LSTCam (Group) ''
Shouldn't the last one have been erased before writing it to the dl2 file?
Hi
Hi @misabelber, What do you mean the last one should be erased? |
Ahhh, ok, nevermind then, I was misunderstanding the structure. In that case, no problem! |
This PR only adds simulation infos to DL1 files following the structure in v5 discussed in cta-observatory/ctapipe#1059
Somehow fixes #119 .
As the DL1 structure is still being discussed, I think we can move forward with the simu info part to at least have this info available to create IRFs.
The events table structure stays untouched so the rest of the code will still work without any change.
I also modify the merge script to append the simu info from each merged file.