Refactoring: Create LST Cleaning Component

[Hckjs]

Referring to #972 and #667, I started refactoring the cleaning by creating a cleaning component which substitutes the cleaning parts in the r0_to_dl1 and dl1ab script.

Main changes:

• There is now the LSTImageCleaner-class with a lot of traits for all the cleaning params and configurable by the config system
• It basically has 3 steps: 1) get pedestal thresholds for tailcuts_clean 2) tailcuts_clean 3) lst_image_cleaning
• the lst_image_cleaning consist of the steps apply_time_delta_cleaning, apply_dynamic_cleaning and selecting the largest_island which can be all turned on/off by the config system
• instead of using the custom code for getting the main/largest island, i switched to the ctapipe function ctapipe.image.morphology.largest_island and renamed it to largest_island because main_island could be a bit ambiguous (main island could be largest or brightest one)
• the standard_config is adapted to the LSTImageCleaner
• the dl1ab-script does not use the LSTImageCleaner yet because it loops over the tables directly via pytables instead of using the EventSource (Want to switch that in a later PR). So the pedestal_cleaning part inside the LSTImageCleaner is not yet used by any script.

Concerns/Thoughts:

• For now, i put the pedestal_cleaning part (i.e. calculating the pedestal thresholds for the tailcuts cleaning) in the call function of the LSTImageCleaner. But that would mean, that the thresholds are calculated again for every image which is a wasted effort (since it is calculated just once per run). But its not yet used as explained in the last bullet point above. So maybe its better to outsource the calculation of the pedestal thresholds outside the eventloop and pass them then to the LSTImageCleaner? idk maybe someone has a good solution for that ...

[codecov]

Codecov Report

Merging #1013 (7e1bf17) into master (ef53179) will increase coverage by 1.69%.
The diff coverage is 91.90%.

❗ Current head 7e1bf17 differs from pull request most recent head 9e0cde0. Consider uploading reports for the commit 9e0cde0 to get more accurate results

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   71.54%   73.23%   +1.69%     
==========================================
  Files         118      119       +1     
  Lines       11251    11308      +57     
==========================================
+ Hits         8049     8281     +232     
+ Misses       3202     3027     -175     

Impacted Files	Coverage Δ
lstchain/scripts/lstchain_dl1ab.py	80.74% <75.00%> (-1.19%)	⬇️
...stchain/calib/camera/pixel_threshold_estimation.py	76.27% <77.27%> (+48.01%)	⬆️
lstchain/reco/r0_to_dl1.py	93.41% <90.43%> (+0.72%)	⬆️
lstchain/image/cleaning.py	96.07% <95.23%> (-3.93%)	⬇️
...ib/camera/tests/test_pixel_threshold_estimation.py	100.00% <100.00%> (ø)
lstchain/image/tests/test_image.py	100.00% <100.00%> (ø)
lstchain/io/config.py	94.87% <100.00%> (ø)
lstchain/io/tests/test_config.py	100.00% <100.00%> (ø)
lstchain/scripts/tests/test_lstchain_scripts.py	99.64% <100.00%> (ø)
lstchain/datachecks/dl1_checker.py	75.73% <0.00%> (+4.50%)	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.