Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: do not use %py_provides for Python 2 #202

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Aug 29, 2024

The macro is not available in EPEL-7 buildroot and causes the build of csdiff to fail:

error: line 79: Unknown tag: %py_provides    python2-csdiff

This partially reverts commit df5c63f.

@kdudka kdudka requested a review from lzaoral August 29, 2024 16:19
@kdudka kdudka self-assigned this Aug 29, 2024
The macro is not available in EPEL-7 buildroot and causes the build
of csdiff to fail:
```
error: line 79: Unknown tag: %py_provides    python2-csdiff
```

This partially reverts commit df5c63f.

Closes: csutils#202
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting. I wonder why this did not happen in EPEL 7 builds in Fedora COPR. 🤔

@kdudka
Copy link
Member Author

kdudka commented Aug 30, 2024

Because there is no (automated) EPEL 7 builds in Fedora COPR I guess.

@kdudka kdudka merged commit f16db5a into csutils:main Aug 30, 2024
32 checks passed
@kdudka kdudka deleted the epel7 branch August 30, 2024 12:48
@lzaoral
Copy link
Member

lzaoral commented Aug 30, 2024

Because there is no (automated) EPEL 7 builds in Fedora COPR I guess.

But we had them for almost two years through Packit until EPEL 7 EOL.

@lzaoral
Copy link
Member

lzaoral commented Aug 30, 2024

This is link to the last Fedora COPR build with EPEL 7: https://copr.fedorainfracloud.org/coprs/g/codescan/csutils/build/7664984/

@kdudka
Copy link
Member Author

kdudka commented Aug 30, 2024

@lzaoral You are right. The EPEL-7 builds in the internal COPR had also been working until yesterday when the mentioned error message popped up. Something must have changed in the EPEL-7 buildroot or in COPR configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants