experimental : postcss-custom-shorthands #647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Oct 15, 2022
| @@ -1,9 +1,8 @@ | |||
| export const packageBabelPreset = [ | |||
| ['@babel/preset-env', { | |||
| corejs: 3, | |||
There was a problem hiding this comment.
I had already fixed this in the v8 branch.
We don't have corejs as a dependency.
This worked because we only wrote JS that didn't need any polyfills from corejs.
css-tree might require a polyfill for typed arrays. (these matches can have false positives)
Removing corejs from our config is the right fix as we never actually had it in the first place.
|
This is likely unimplementable : w3c/csswg-drafts#7879 (comment) |
| { | ||
| "name": "@csstools/postcss-custom-shorthands-experimental", | ||
| "description": "Research plugin for a Custom Shorthands proposal", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
Should this be in the 0.0.x realm?
|
So I like this a lot! Love the versions too I'm wondering a couple of things
|
|
Closing because it can not be implemented. Thank your for reviewing @Antonio-Laguna 🙇 |
romainmenke
deleted the
experimental--postcss-custom-shorthands--frank-mule-a61dcf3ff2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see : w3c/csswg-drafts#7879
Notes :
This plugin introduces
css-treeas a dependency.I am fine with having it as a workspace dependency but if this feature ever becomes a real thing I prefer writing our own syntax definition parser from scratch. I don't like the bloat of having all of
css-treefor this single parser. see : https://www.w3.org/TR/css-properties-values-api-1/#parsing-syntaxThis package was quickly written and lacks sufficient test coverage and coding style is not ideal in places. This is fine for now I think, as we will end up trashing it later. Better to start from scratch if we ever build this for real.
Custom data in VSCode has this effect :
A real plugin would not have this feature as we would rely on editors to do this work themselves. But it is useful to get a glimpse of the real author experience.