This repository has been archived by the owner on Jun 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Because the default wrap, modify the document and test file.
- Loading branch information
Ҽ˿
committed
Dec 6, 2014
1 parent
dc46fbb
commit cc35989
Showing
6 changed files
with
65 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
section h1, article h1, aside h1, nav h1 { | ||
section h1, | ||
article h1, | ||
aside h1, | ||
nav h1 { | ||
margin-top: 16px; | ||
} | ||
|
||
main input[type="text"] > section + p, main #nav .bar + p { | ||
main input[type="text"] > section + p, | ||
main #nav .bar + p { | ||
margin-top: 16px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
@custom-selector --heading h1, h2, h3, h4, h5, h6; | ||
|
||
article --heading + p{ | ||
article --heading + p { | ||
margin-top: 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,8 @@ | ||
article h1 + p, article h2 + p, article h3 + p, article h4 + p, article h5 + p, article h6 + p{ | ||
article h1 + p, | ||
article h2 + p, | ||
article h3 + p, | ||
article h4 + p, | ||
article h5 + p, | ||
article h6 + p { | ||
margin-top: 0; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.foo > a::before img, .foo > a::after img { | ||
.foo > a::before img, | ||
.foo > a::after img { | ||
display: block; | ||
} |
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see here that these kind of changes can affect existing code. That's why you should release this kind of features as major release (in this case you should had released 2.0.0 because of this breaking change). This is how semver works http://semver.org/
Don't be afraid to do major bump (some browsers are not for example ^^), that will prevent issue like this https://travis-ci.org/cssnext/cssnext/builds/44115199 (build is broken because I have used
"^1.0.0"
when I install this module, so it's getting 1.1.0).Also interesting to read https://github.com/jonathanong/ferver
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a big deal for this time (cause just a few people are using it right now) but that advice is for the future :)
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the next, I will pay attention to this problem.
I'm very sorry, I don't have much experience.
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. That's why I take time to explain this to you. I hope you have learned something ;)
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are all noobs.
cc35989
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a sub company called the "noobs network" 😭