Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Apache xmlgraphics-commons #99

Closed
carlosame opened this issue May 10, 2024 · 1 comment
Closed

Remove Apache xmlgraphics-commons #99

carlosame opened this issue May 10, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file
Milestone
1.2

Comments

@carlosame
Copy link
Member

carlosame commented May 10, 2024 •
edited
Loading

EchoSVG depends on the Apache xmlgraphics-commons project to implement color conversion support for the deprecated SVG 1.1 colors. The color conversions in that module were written with deprecated specifications in mind and therefore lack modern features.
@carlosame carlosame added the dependencies Pull requests that update a dependency file label May 10, 2024
@carlosame carlosame added this to the 1.1 milestone May 10, 2024
carlosame added a commit that referenced this issue Jun 13, 2024
@carlosame
Modules: switch to org.apache.xmlgraphics.commons as xmlgraphics-co…
ca22085 
…mmons module name

First step towards #99
@carlosame carlosame modified the milestones: 1.1, 1.1.1, 1.1.2, 1.2 Jul 24, 2024
@carlosame carlosame changed the title Upgrade to next Apache xmlgraphics-commons when available Remove Apache xmlgraphics-commons Jul 30, 2024
@carlosame
Copy link
Member Author

To achieve that, move the necessary xmlgraphics-commons packages into a new module inside EchoSVG. Eventually replace the deprecated SVG features with modern CSS Colors.

It is worth mentioning that this affects only the deprecated SVG 1.1 color extensions, because for the color conversions of non-deprecated colors, EchoSVG has been using the css4j color infrastructure which is far more modern and offers advanced features like an accurate gamut clamping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@carlosame