Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcoder disallows valid script media types #56

Closed
carlosame opened this issue Jul 27, 2022 · 0 comments
Closed

Transcoder disallows valid script media types #56

carlosame opened this issue Jul 27, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@carlosame
Copy link
Member

The transcoder keeps a list of allowed script media types based on the KEY_ALLOWED_SCRIPT_TYPES hint, which by default is:

"text/ecmascript, application/ecmascript, text/javascript, application/javascript, application/java-archive"

Note the whitespaces after the commas. Given to how it is parsed, the mime types are stored with a whitespace at the beginning, resulting in only the first item of the list actually matching the contains mime type check:

As a result, valid script media types are not allowed.

@carlosame carlosame added the bug Something isn't working label Jul 27, 2022
@carlosame carlosame added this to the 0.2.1 milestone Jul 27, 2022
@carlosame carlosame self-assigned this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant