Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 18 deprecates finalization for removal #38

Closed
carlosame opened this issue Jan 25, 2022 · 1 comment
Closed

JDK 18 deprecates finalization for removal #38

carlosame opened this issue Jan 25, 2022 · 1 comment
Assignees
@carlosame
Labels
deprecation Something was deprecated
Milestone
0.2

Comments

@carlosame
Copy link
Member

Forthcoming JDK 18 deprecates finalization for removal, see JEP 421 for details.

EchoSVG uses finalization in two places:

echosvg/echosvg-bridge/src/main/java/io/sf/carte/echosvg/bridge/BridgeContext.java

Line 311 in 298d49e

protected void finalize() {

echosvg/echosvg-transcoder/src/main/java/io/sf/carte/echosvg/ext/awt/image/codec/util/SeekableStream.java

Line 980 in 298d49e

protected void finalize() throws Throwable {

and the code should be changed so the finalize() can be removed in favor of a more modern construct.
@carlosame carlosame added the deprecation Something was deprecated label Jan 25, 2022
carlosame added a commit that referenced this issue Apr 24, 2022
@carlosame
transcoder: remove finalize() method from SeekableStream. See #38
270cdf1
carlosame added a commit that referenced this issue Jun 19, 2022
@carlosame
bridge: rename finalize() to close(), implement Closeable in BridgeCo…
95c8bea 
…ntext

See #38.
@carlosame carlosame self-assigned this Jun 19, 2022
@carlosame carlosame added this to the 0.2 milestone Jun 19, 2022
@carlosame
Copy link
Member Author

After 95c8bea there are no more finalize() methods. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosame carlosame

Labels
deprecation Something was deprecated
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@carlosame