Fix class naming, path resolution, and broken tests on Windows #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 10, 2015 22:34
…tead of _relative_path_to_file) and broken path resolution ("composes" didn't work)
…ing on Windows and Mac.
…o better reflect the path to the imported style
…or old versions of Node
|
👍 merge please ! |
|
+1 |
|
Really hackish. Let say the original path is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this together to resolve #16, and have tested it on Windows and Mac.
It requires a bit of a hack to the postcss-modules-scope plugin. PostCSS converts the "from" path to an absolute path, so I've adjusted the scope plugin's generateScopedName function to make the path (and hence class name) relative to the FileSystemLoader's root.