Catch unhandled promise rejection events

[jh3141]

Promise rejection events can be caught via the window.onunhandledrejection event. If an exception is thrown during processing of a Promise (either during its initial execution phase or during processing a "then" function attached to it), the Promise is rejected and the "reason" entry in the rejection event will be an Error. reason may also be any other type, as it will be populated with whatever argument is given in calls to the reject function of the Promise handler, so will need to be checked before handling. I'm not sure how TraceKit should behave if it catches an unhandled rejection that is not an Error.

Support for this feature of Promises isn't great yet, but is improving (see http://caniuse.com/#feat=unhandledrejection).

[niemyjski]

Can you submit a pr for this?

[niemyjski]

@jh3141 can you submit a pr for this

[ghostd]

Here is a PR: #73

[ghostd]

Hi @niemyjski

Can we close this issue and bump the version please? I'd like to update my deps with a version handling the promises.

Thx

[niemyjski]

@ghostd yes, I'll cut a release. I was just trying to get #68 merged in as well.

[niemyjski]

Could you please review this as well

[adams-family]

I confirm that 'Possible unhandled rejections' are still not being caught at this moment. Is there a workaround for this? Thanks.

[niemyjski]

I was under the impression that this has been fixed. Can you please add some tests or send us a demo that fails and let us know under which browser it fails. Thanks -Blake Niemyjski

…

On Mon, Sep 9, 2019 at 5:02 AM adams-family ***@***.***> wrote: I confirm that 'Possible unhandled rejections' are still not being caught at this moment. Is there a workaround for this? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72?email_source=notifications&email_token=AAHZFI7BIHFYZJWLWWFURGLQIYNJZA5CNFSM4D5ULO32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6G7A5A#issuecomment-529395828>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZFI2SLR5HTNAWNJK4PRDQIYNJZANCNFSM4D5ULO3Q> .

[adams-family]

Hi Blake,
Sorry for the late answer, I managed to create a demo of my issue.
Just open index.html and look at the F12 console. You'll see a Possible unhandled rejection not being caught by Tracekit.
Maybe it's beacuse of something stupid but it wasn't able to figure it out.
Thanks, Adam

Demo.zip

[erikdubbelboer]

Since this has been merged is there any plan to tag a new release?

[niemyjski]

I've pushed this in a release, sorry for the delay: https://github.com/csnover/TraceKit/releases/tag/v0.4.6