Introduce v1beta1 CRD for replication objects. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
humblec
changed the title
humblec
changed the title
humblec
force-pushed
the
update
branch
9 times, most recently
from
6ee46b2
to
aa3adac
Compare
This commit add v1beta1 CRD version for the replication objects and also update the CRD manifests. Addition to that, bundle version has been updated to v0.0.2 boilerplate header has been updated to reflect current year. Fix: csi-addons#122 Signed-off-by: Humble Chirammal <[email protected]>
ShyamsundarR
reviewed
Jun 9, 2022
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1beta1 |
There was a problem hiding this comment.
I am not sure we are ready for beta yet!
There was a problem hiding this comment.
@Madhu-1 any thoughts from your end ?
There was a problem hiding this comment.
Yes as discussed we are planning to move volRep to csiaddons, we aren't ready to move to beta Yet.
This avoid below error: Error: hugeParam: r is heavy (80 bytes); consider passing it by pointer (gocritic) Signed-off-by: Humble Chirammal <[email protected]>
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does number of things
Fix # #122
Signed-off-by: Humble Chirammal [email protected]