Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "vendor: bump github.com/operator-framework/operator-sdk" #143

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Revert "vendor: bump github.com/operator-framework/operator-sdk" #143

merged 1 commit into from
Apr 12, 2022

Conversation

Rakshith-R
Copy link
Member

This reverts commit be81d55.
This is done since bundle_builds are failing.

Signed-off-by: Rakshith R [email protected]

Refer: https://github.com/csi-addons/kubernetes-csi-addons/runs/5991350174?check_suite_focus=true#step:4:16

go build -o /home/runner/work/kubernetes-csi-addons/kubernetes-csi-addons/bin/operator-sdk ./vendor/github.com/operator-framework/operator-sdk/cmd/operator-sdk
# github.com/deislabs/oras/pkg/oras
Error: vendor/github.com/deislabs/oras/pkg/oras/push.go:52:31: not enough arguments in call to remotes.PushContent
	have (context.Context, remotes.Pusher, v1.Descriptor, "github.com/containerd/containerd/content".Store, nil, func(images.Handler) images.Handler)
	want (context.Context, remotes.Pusher, v1.Descriptor, "github.com/containerd/containerd/content".Store, *semaphore.Weighted, platforms.MatchComparer, func(images.Handler) images.Handler)
make: *** [Makefile:203: operator-sdk] Error 2

@Rakshith-R
Revert "vendor: bump github.com/operator-framework/operator-sdk"
e6923f2 
This reverts commit be81d55.
This is done since bundle_builds are failing.

Signed-off-by: Rakshith R <[email protected]>
@mergify mergify bot added the vendor Pull requests that update vendored dependencies label Apr 12, 2022
@mergify mergify bot requested review from nixpanic, yati1998 and Yuggupta27 April 12, 2022 14:09
@Rakshith-R Rakshith-R marked this pull request as draft April 12, 2022 14:13
@Rakshith-R Rakshith-R marked this pull request as ready for review April 12, 2022 14:58
@Rakshith-R Rakshith-R requested a review from Madhu-1 April 12, 2022 14:58
@Rakshith-R
Copy link
Member Author

#144 is not sufficient
it still hits operator-framework/operator-sdk#5574.
PTAL @csi-addons/kubernetes-csi-addons-contributors

@nixpanic nixpanic mentioned this pull request Apr 12, 2022
Merged
@mergify mergify bot merged commit 213c08a into csi-addons:main Apr 12, 2022
nixpanic pushed a commit to nixpanic/kubernetes-csi-addons that referenced this pull request Jun 20, 2024
@openshift-merge-bot
Merge pull request csi-addons#143 from red-hat-storage/sync_ds--main
d2c2455 
Syncing latest changes from main for kubernetes-csi-addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 Awaiting requested review from yati1998

@Yuggupta27 Yuggupta27 Awaiting requested review from Yuggupta27

Assignees
No one assigned
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rakshith-R @nixpanic @Madhu-1