Prototype: Arithmetic Types #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this prototype, the complex.js and fraction.js packages were replaced with versions that support Arithmetic Types. The Arithmetics object for the
numbertype was also implemented.The
NormedDivisionRingtype was added to thetypedfunction. Therefore, math.js recognizesnumber,ComplexandFractionas instances ofNormedDivisionRingand is able to perform operations on them. This has been used to simplify the logic inexp,log. It has also been demonstrated that the approach works for multiargument functions likeaddScalar.To demonstrate the flexibility of this new system, a unit test was added, which demonstrates that math.js functions now work even with external types, without any need for prior configuration.
A working example of
BigNumberwith arithmetic types was not provided because of time constraints – the class is constructed dynamically by math.js which makes it more difficult to maintain an up-to-date Arithmetics object.