Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cookiecutter #96

Merged
merged 38 commits into from
Apr 5, 2024
Merged

Replace cookiecutter #96

merged 38 commits into from
Apr 5, 2024

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Apr 2, 2024

This pull request removes the babelizer's dependency on cookiecutter by adding its own (simplified) version of cookiecutter. cookiecutter seemed to be overkill for what we were using it for here.

@mcflugen mcflugen requested a review from mdpiper April 3, 2024 15:32
Copy link
Member

@mdpiper mdpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a neat idea!

Comment on lines 2 to 3
include LICENSE
include requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

@@ -1,15 +1,15 @@
recursive-include {{ cookiecutter.package_name }}/data *
recursive-include {{ package.name }}/data *
include LICENSE
include requirements.txt
include *.rst
include *.txt
include Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

include LICENSE
include requirements.txt
include *.rst
include *.txt
include Makefile
include babel.toml
recursive-include {{ cookiecutter.package_name }} *.pyx
recursive-include {{ package.name }} *.pyx
recursive-include docs *.py
recursive-include docs *.rst
recursive-include docs Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete in favor of build-docs session

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went ahead and removed the entire manifest file and added a tool.setuptools.package-data section in pyproject.toml for python projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete in favor of nox build-docs session?

@mcflugen mcflugen merged commit 8b84c83 into develop Apr 5, 2024
36 checks passed
@mcflugen mcflugen deleted the mcflugen/replace-cookiecutter branch April 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants